Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

kafka src/binding type bumps #1294

Merged
merged 1 commit into from
Jun 24, 2020
Merged

kafka src/binding type bumps #1294

merged 1 commit into from
Jun 24, 2020

Conversation

matzew
Copy link
Member

@matzew matzew commented Jun 3, 2020

Signed-off-by: Matthias Wessendorf [email protected]

Fixes #

Proposed Changes

  • bump types to v1beta1

Release Note

NONE (missing reconcilers, etc. just the types).

Docs

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 3, 2020
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release labels Jun 3, 2020
@matzew
Copy link
Member Author

matzew commented Jun 3, 2020

/test pull-knative-eventing-contrib-integration-tests

@matzew matzew changed the title WIP: kafka src/binding type bumps kafka src/binding type bumps Jun 3, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2020
n3wscott
n3wscott reviewed Jun 3, 2020
View reviewed changes
kafka/source/pkg/apis/sources/v1beta1/kafka_types.go Outdated

// Sink is a reference to an object that will resolve to a domain name to use as the sink.
// +optional
Sink *duckv1.Destination `json:"sink,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flatten this to import the base source duck:

	// inherits duck/v1 SourceSpec, which currently provides:
	// * Sink - a reference to an object that will resolve to a domain name or
	//   a URI directly to use as the sink.
	// * CloudEventOverrides - defines overrides to control the output format
	//   and modifications of the event sent to the sink.
	duckv1.SourceSpec `json:",inline"`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this! I should have looked on the other sources first :-)

n3wscott
n3wscott reviewed Jun 3, 2020
View reviewed changes
kafka/source/pkg/apis/sources/v1beta1/kafka_types.go Outdated

// ServiceAccoutName is the name of the ServiceAccount that will be used to run the Receive
// Adapter Deployment.
ServiceAccountName string `json:"serviceAccountName,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really - thanks, Updated that @n3wscott

mattmoor
mattmoor reviewed Jun 4, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

mattmoor
mattmoor reviewed Jun 4, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

mattmoor
mattmoor reviewed Jun 4, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

mattmoor
mattmoor reviewed Jun 5, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

mattmoor
mattmoor reviewed Jun 5, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

mattmoor
mattmoor reviewed Jun 5, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

@matzew
💫 kafka src/binding type bumps
7ce37e0 
Signed-off-by: Matthias Wessendorf <[email protected]>
mattmoor
mattmoor reviewed Jun 22, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v wire_gen.go)

kafka/source/pkg/apis/sources/v1alpha1/kafka_conversion.go

import (
"context"
"fmt"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format Go code:

Suggested change
"fmt"
"fmt"
"reflect"

kafka/source/pkg/apis/sources/v1alpha1/kafka_conversion.go
"knative.dev/eventing-contrib/kafka/source/pkg/apis/sources/v1beta1"
"knative.dev/pkg/apis"
duckv1 "knative.dev/pkg/apis/duck/v1"
"reflect"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format Go code:

Suggested change
"reflect"

kafka/source/pkg/apis/sources/v1beta1/kafka_conversion.go

import (
"context"
"fmt"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format Go code:

Suggested change
"fmt"
"fmt"

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
kafka/source/pkg/apis/bindings/v1beta1/kafka_defaults.go Do not exist 0.0%
kafka/source/pkg/apis/bindings/v1beta1/kafka_lifecycle.go Do not exist 56.1%
kafka/source/pkg/apis/bindings/v1beta1/kafka_validation.go Do not exist 0.0%
kafka/source/pkg/apis/bindings/v1beta1/register.go Do not exist 100.0%
kafka/source/pkg/apis/sources/v1alpha1/kafka_conversion.go Do not exist 0.0%
kafka/source/pkg/apis/sources/v1beta1/kafka_conversion.go Do not exist 100.0%
kafka/source/pkg/apis/sources/v1beta1/kafka_defaults.go Do not exist 100.0%
kafka/source/pkg/apis/sources/v1beta1/kafka_lifecycle.go Do not exist 57.9%
kafka/source/pkg/apis/sources/v1beta1/kafka_types.go Do not exist 50.0%
kafka/source/pkg/apis/sources/v1beta1/kafka_validation.go Do not exist 85.7%
kafka/source/pkg/apis/sources/v1beta1/register.go Do not exist 100.0%

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jun 22, 2020 •
edited
Loading

@matzew: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-contrib-go-coverage 7ce37e0 link /test pull-knative-eventing-contrib-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@matzew
Copy link
Member Author

matzew commented Jun 22, 2020

/test pull-knative-eventing-contrib-integration-tests

@aliok aliok mentioned this pull request Jun 22, 2020
Closed
9 tasks
@aliok
Copy link
Member

aliok commented Jun 22, 2020

Created #1332 for reconciler work

aliok
aliok approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Let's merge this and I can start with the reconciler work

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 89f7859 into knative:master Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@n3wscott n3wscott n3wscott left review comments

@mattmoor mattmoor mattmoor left review comments

@aliok aliok aliok approved these changes

@lberk lberk Awaiting requested review from lberk

@steuhs steuhs Awaiting requested review from steuhs

Assignees

@aliok aliok

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@matzew @knative-metrics-robot @knative-prow-robot @aliok @mattmoor @n3wscott @googlebot