Update API build and generate 0.19 API docs #3043
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RichieEscarez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
approved
size/XXL
docs/reference/api/README.md
Outdated
|
|
||
| * If you get the | ||
| `F0807 13:58:20.621526 168834 main.go:444] type invalid type has kind=Unsupported which is unhandled` | ||
| error, the import target might have moved. For more details and an example, |
There was a problem hiding this comment.
| error, the import target might have moved. For more details and an example, | |
| error, the import target might have moved. For more details, and an example, |
I'm bad at punctuation, maybe the above update looks correct ^
There was a problem hiding this comment.
Thanks Mike! Here is the style guide we use for Knative: https://developers.google.com/style/commas
There was a problem hiding this comment.
I've been really busy this week and decided to add the details about the issue i faced this week and quickly dumped details about an issue from the past. I took a second pass at this to better explain. PTAL
Co-authored-by: Mike Petersen <[email protected]>
|
@mpetason if you are okay with the text, can you provide the LTGM so that we can merge this and unblock the 0.19 docs release? |
|
/lgtm |
* remove eventing-contrib * update gen-crd-api-reference-docs version to fix API build errors * API docs build for 0.19 * revert API version and add troubleshooting docs * revert file * remove whitespace * Update docs/reference/api/README.md Co-authored-by: Mike Petersen <[email protected]> * add more detail * and now fix my typo Co-authored-by: Mike Petersen <[email protected]>
Related: knative/website#240
Staged: https://5fb326fd6fbbcb00e3428a3a--knative.netlify.app/docs/reference/api/
cc/ @vaikas @lionelvillard