We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We've hello world test image source in repo, https://github.com/knative/client/tree/master/test/test_images/helloworld and not being built and referenced in tests. The image used in tests gcr.io/knative-samples/helloworld-go is stale, last updated on Nov 2018. We should be building and using this helloworld test image during e2e test run. Recently there was a h2c port name PR landed which is also missing e2e tests, we can build this image in CI for tests cc: @itsmurugappan.
h2c
https://github.com/knative/eventing/tree/master/test#test-images
/area e2e /kind proposal
The text was updated successfully, but these errors were encountered:
Yes, we could do like serving, where we initially specify the KO_DOCKER_REPO.
Sorry, something went wrong.
/assign
itsmurugappan
Successfully merging a pull request may close this issue.
Feature request
We've hello world test image source in repo, https://github.com/knative/client/tree/master/test/test_images/helloworld and not being built and referenced in tests. The image used in tests gcr.io/knative-samples/helloworld-go is stale, last updated on Nov 2018.
We should be building and using this helloworld test image during e2e test run.
Recently there was a
h2c
port name PR landed which is also missing e2e tests, we can build this image in CI for tests cc: @itsmurugappan.References:
https://github.com/knative/eventing/tree/master/test#test-images
/area e2e
/kind proposal
The text was updated successfully, but these errors were encountered: