Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Build and use e2e test images from repo source code #942

Closed
navidshaikh opened this issue Jul 21, 2020 · 2 comments · Fixed by #974
Closed

e2e: Build and use e2e test images from repo source code #942

navidshaikh opened this issue Jul 21, 2020 · 2 comments · Fixed by #974
Assignees
Labels
area/e2e kind/feature New feature or request kind/proposal Issues or PRs related to proposals.
Milestone

Comments

@navidshaikh
Copy link
Collaborator

Feature request

We've hello world test image source in repo, https://github.com/knative/client/tree/master/test/test_images/helloworld and not being built and referenced in tests. The image used in tests gcr.io/knative-samples/helloworld-go is stale, last updated on Nov 2018.
We should be building and using this helloworld test image during e2e test run.
Recently there was a h2c port name PR landed which is also missing e2e tests, we can build this image in CI for tests cc: @itsmurugappan.

References:

https://github.com/knative/eventing/tree/master/test#test-images

/area e2e
/kind proposal

@itsmurugappan
Copy link
Contributor

Yes, we could do like serving, where we initially specify the KO_DOCKER_REPO.

@itsmurugappan
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/e2e kind/feature New feature or request kind/proposal Issues or PRs related to proposals.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants