Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --ce-override on ping and apiserver sources #849

Closed
jchesterpivotal opened this issue May 20, 2020 · 2 comments · Fixed by #865
Closed

Support --ce-override on ping and apiserver sources #849

jchesterpivotal opened this issue May 20, 2020 · 2 comments · Fixed by #865
Assignees
Labels
kind/feature New feature or request
Milestone

Comments

@jchesterpivotal
Copy link

jchesterpivotal commented May 20, 2020

Feature request

All Source-ducktyped objects include a CloudEventOverride, which serializes as extensions. In kn, this is exposed as an option for source binding create and source binding update, but not for comparable commands on ping and apiserver command groups.

Also print the cloud event overrides extensions in describe output for sources if present.

The request is to add identical support to these other sources for consistency.

@jchesterpivotal jchesterpivotal added the kind/feature New feature or request label May 20, 2020
@navidshaikh navidshaikh added this to the v0.15.0 milestone May 28, 2020
@navidshaikh
Copy link
Collaborator

/assign

@navidshaikh
Copy link
Collaborator

@jchesterpivotal : I've updated the issue description to also print the ce-overrides values in describe output if present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants