Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "--annotation-service" and "--annotation-revision" to kn service create/update #1014

Closed
rhuss opened this issue Sep 15, 2020 · 2 comments · Fixed by #1029
Closed

Add "--annotation-service" and "--annotation-revision" to kn service create/update #1014

rhuss opened this issue Sep 15, 2020 · 2 comments · Fixed by #1029
Assignees
Labels
kind/feature New feature or request
Milestone

Comments

@rhuss
Copy link
Contributor

rhuss commented Sep 15, 2020

Feature request

In order to provide the same support as for labels also for annotations, the two options mentioned in the title should be implemented with the same semantics as for labels:

-l, --label stringArray             Labels to set for both Service and Revision. name=value; you may provide this flag any number of times to set
                                      multiple labels. To unset, specify the label name followed by a "-" (e.g., name-).
      --label-revision stringArray    Revision label to set. name=value; you may provide this flag any number of times to set multiple labels. To unset,
                                      specify the label name followed by a "-" (e.g., name-). This flag takes precedence over "label" flag.
      --label-service stringArray     Service label to set. name=value; you may provide this flag any number of times to set multiple labels. To unset,
                                      specify the label name followed by a "-" (e.g., name-). This flag takes precedence over "label" flag.

Use case

One use case is to add sidecar.istio.io/inject: "true" annotation to the pod template which is currently not possible.

cc: @nak3

@rhuss rhuss added the kind/feature New feature or request label Sep 15, 2020
@navidshaikh
Copy link
Collaborator

/assign

@arghya88
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants