Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--min-scale/max-scale are broken #1008

Closed
duglin opened this issue Sep 12, 2020 · 2 comments · Fixed by #1010
Closed

--min-scale/max-scale are broken #1008

duglin opened this issue Sep 12, 2020 · 2 comments · Fixed by #1010
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@duglin
Copy link
Contributor

duglin commented Sep 12, 2020

the latest kn seems to support --min-scale and --max-scale, at least it doesn't complain when I try to use them. But nothing is set in the ksvc - so they have no effect. If we're not going to generate an error (due to them not being valid flag) then we should still support them on the backend properly.

I suspect this might catch a lot of people - took me a while to figure out why my services kept scaling down to zero despite specifying --min-scale=1 :-)

IMO we should back-port the fix for this

@duglin duglin added the kind/bug Categorizes issue or PR as related to a bug. label Sep 12, 2020
@mpetason
Copy link
Contributor

/assign

@navidshaikh
Copy link
Collaborator

navidshaikh commented Sep 14, 2020

Thanks Doug! This should've been caught in e2e, which alerts missing e2e. The fix should contain e2e for hidden variant of these flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants