From 90b7c31d3404f85bad999c8a5369f5481395b293 Mon Sep 17 00:00:00 2001 From: toversus Date: Fri, 6 Sep 2019 09:29:38 +0900 Subject: [PATCH] Unify the terms used --- pkg/serving/config_changes.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/serving/config_changes.go b/pkg/serving/config_changes.go index d7c977eb67..1bc7ca1f82 100644 --- a/pkg/serving/config_changes.go +++ b/pkg/serving/config_changes.go @@ -32,7 +32,7 @@ var UserImageAnnotationKey = "client.knative.dev/user-image" // UpdateEnvVars gives the configuration all the env var values listed in the given map of // vars. Does not touch any environment variables not mentioned, but it can add -// new env vars and change the values of existing ones, then sort by environment key name. +// new env vars and change the values of existing ones, then sort by env key name. func UpdateEnvVars(template *servingv1alpha1.RevisionTemplateSpec, toUpdate map[string]string, toRemove []string) error { container, err := ContainerOfRevisionTemplate(template) if err != nil { @@ -40,7 +40,7 @@ func UpdateEnvVars(template *servingv1alpha1.RevisionTemplateSpec, toUpdate map[ } updated := updateEnvVars(container.Env, toUpdate) removed := removeEnvVars(updated, toRemove) - // Sort by Env key name + // Sort by env key name sort.SliceStable(removed, func(i, j int) bool { return removed[i].Name < removed[j].Name })