Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner can hang forever while stopping, when executed on fast rendering setups #160

Closed
cardil opened this issue Mar 21, 2024 · 1 comment · Fixed by #162
Closed

Spinner can hang forever while stopping, when executed on fast rendering setups #160

cardil opened this issue Mar 21, 2024 · 1 comment · Fixed by #162
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@cardil
Copy link
Contributor

cardil commented Mar 21, 2024

On some fast rendering setups like:

  • unit tests,
  • background processes,
  • pipe'ing output/input

the spinner could hang indefinitely on Quit(), and Wait() method:

b.tea.Quit()
b.tea.Wait()

See the goroutines dump: https://gist.github.com/cardil/039c0691d94b9537126b50361bbf9d3e

/kind bug

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 21, 2024
@cardil
Copy link
Contributor Author

cardil commented Mar 21, 2024

/assign

@cardil cardil changed the title Spinner can hang forever on stop(), when executed on fast rendering setups Spinner can hang forever while stopping, when executed on fast rendering setups Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant