diff --git a/pkg/credentials/gitcreds/ssh.go b/pkg/credentials/gitcreds/ssh.go index 8107419c..f6d2b2cc 100644 --- a/pkg/credentials/gitcreds/ssh.go +++ b/pkg/credentials/gitcreds/ssh.go @@ -57,13 +57,13 @@ func (dc *sshGitConfig) String() string { func (dc *sshGitConfig) Set(value string) error { parts := strings.Split(value, "=") if len(parts) != 2 { - return fmt.Errorf("Expect entries of the form secret=url, got: %v", value) + return fmt.Errorf("expect entries of the form secret=url, got: %v", value) } secret := parts[0] url := parts[1] if _, ok := dc.entries[url]; ok { - return fmt.Errorf("Multiple entries for url: %v", url) + return fmt.Errorf("multiple entries for url: %v", url) } e, err := newSshEntry(url, secret) diff --git a/pkg/logs/logs.go b/pkg/logs/logs.go index 4cb1277e..caf45814 100644 --- a/pkg/logs/logs.go +++ b/pkg/logs/logs.go @@ -45,7 +45,7 @@ func Tail(ctx context.Context, out io.Writer, buildName, namespace string) error podName, err := podName(cfg, out, buildName, namespace) if err != nil { - return fmt.Errorf("Error getting build pod: %v", err) + return fmt.Errorf("error getting build pod: %v", err) } client, err := corev1.NewForConfig(cfg) @@ -213,13 +213,13 @@ func streamLogs(ctx context.Context, out io.Writer, containerName string, rc io. func podName(cfg *rest.Config, out io.Writer, buildName, namespace string) (string, error) { client, err := buildv1alpha1.NewForConfig(cfg) if err != nil { - return "", fmt.Errorf("Error getting build client: %v", err) + return "", fmt.Errorf("error getting build client: %v", err) } for ; ; time.Sleep(time.Second) { b, err := client.Builds(namespace).Get(buildName, metav1.GetOptions{IncludeUninitialized: true}) if err != nil { - return "", fmt.Errorf("Error getting build: %v", err) + return "", fmt.Errorf("error getting build: %v", err) } cluster := b.Status.Cluster diff --git a/pkg/reconciler/build/resources/pod.go b/pkg/reconciler/build/resources/pod.go index 588e5858..bf210252 100644 --- a/pkg/reconciler/build/resources/pod.go +++ b/pkg/reconciler/build/resources/pod.go @@ -354,7 +354,7 @@ func MakePod(build *v1alpha1.Build, kubeclient kubernetes.Interface) (*corev1.Po if build.Status.Cluster != nil && build.Status.Cluster.PodName != "" { podName = build.Status.Cluster.PodName } else { - return nil, fmt.Errorf("Can't create pod for build %q: pod name not set", build.Name) + return nil, fmt.Errorf("can't create pod for build %q: pod name not set", build.Name) } return &corev1.Pod{ @@ -420,7 +420,7 @@ func BuildStatusFromPod(p *corev1.Pod, buildSpec v1alpha1.BuildSpec) v1alpha1.Bu // is the source-fetching container. skip++ } - // Also skip multiple sourcees specified by the build. + // Also skip multiple sources specified by the build. skip += len(buildSpec.Sources) if skip <= len(p.Status.InitContainerStatuses) { for _, s := range p.Status.InitContainerStatuses[skip:] { diff --git a/roadmap-2018.md b/roadmap-2018.md index ee94a363..0f03ef26 100644 --- a/roadmap-2018.md +++ b/roadmap-2018.md @@ -46,7 +46,7 @@ advances we've made with FTL-like layer caching techniques, [remote image rebasing](https://github.com/google/image-rebase), source detection, and in general be best-in-class in terms of fast incremental builds. -[GCB](cloud.google.com/container-builder/docs) already maintains a set of +[GCB](https://cloud.google.com/cloud-build/docs/) already maintains a set of [officially-supported builders](https://github.com/GoogleCloudPlatform/cloud-builders), and some [contributed by community members](https://github.com/GoogleCloudPlatform/cloud-builders-community). diff --git a/test/e2e/README.md b/test/e2e/README.md index 6ffa9e11..e2b4881c 100644 --- a/test/e2e/README.md +++ b/test/e2e/README.md @@ -1,6 +1,6 @@ # End to end tests -- [Running e2e tests](../README.md#running-e2e-tests) +- [Running e2e tests](../README.md#Running-end-to-end-tests) ## Adding end to end tests @@ -17,4 +17,4 @@ The e2e tests **MUST**: 1. Provide frequent output describing what actions they are undertaking, especially before performing long running operations. -2. Follow Golang best practices. +1. Follow Golang best practices.