Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bash scripts work for Bash v4+ #638

Closed
carlisia opened this issue Oct 13, 2021 · 2 comments
Closed

Make bash scripts work for Bash v4+ #638

carlisia opened this issue Oct 13, 2021 · 2 comments
Assignees

Comments

@carlisia
Copy link
Member

Some bash scripts in this repo have #!/bin/bash at the top of the file. They need to have #!/usr/bin/env bash so it will pick up updated versions of bash on MacOS.

It should have no other side effect.

For context: for virtually any knative script to be run, the bash version needs to be v4+. See knative/test-infra#2143 for background.

@carlisia
Copy link
Member Author

/assign carlisia

@carlisia carlisia changed the title Make scripts/library.sh work for Bash v4+ Make bash scripts work for Bash v4+ Oct 13, 2021
@dprotaso
Copy link
Contributor

closing since #634 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants