Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing custom flags to minikube #557

Open
segevfiner opened this issue Dec 5, 2024 · 3 comments
Open

Allow passing custom flags to minikube #557

segevfiner opened this issue Dec 5, 2024 · 3 comments
Labels
triage/accepted Issues which should be fixed (post-triage)

Comments

@segevfiner
Copy link

e.g. kn quickstart minikube -- --ports=8080

Should be simple to support by just passing everything after a -- to minikube start

@psschwei
Copy link
Contributor

psschwei commented Dec 5, 2024

Out of curiosity, do you just need this to reach a port or are there other configs you'd like to set on minikube too?

Not opposed to this in principle, just trying to get a sense of your needs.

@segevfiner
Copy link
Author

I happened to try adding a port for some UDP service, but there are plenty that are useful https://minikube.sigs.k8s.io/docs/commands/start/, e.g. image-repository to use a mirror, gpus to allow gpus, and so on, there are many different flags which is why I suggested a passthrough rather than trying to wrap every single flag minikube ever or will implement.

@psschwei
Copy link
Contributor

psschwei commented Dec 5, 2024

/triage accepted

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

2 participants