From e9a3897c5dd274f65b42504b742a858d2a3ca4d9 Mon Sep 17 00:00:00 2001
From: Knative Prow Robot <knative-prow-robot@google.com>
Date: Fri, 10 Jun 2022 04:26:25 -0700
Subject: [PATCH] require manual minikube tunnel on linux too (#302)

Signed-off-by: Paul S. Schweigert <paulschw@us.ibm.com>

Co-authored-by: Paul S. Schweigert <paulschw@us.ibm.com>
---
 pkg/install/install.go   | 12 ------------
 pkg/minikube/minikube.go | 15 ++++++---------
 2 files changed, 6 insertions(+), 21 deletions(-)

diff --git a/pkg/install/install.go b/pkg/install/install.go
index 74d202d7..8582fce2 100644
--- a/pkg/install/install.go
+++ b/pkg/install/install.go
@@ -17,7 +17,6 @@ package install
 import (
 	"fmt"
 	"os/exec"
-	"runtime"
 	"strings"
 	"time"
 )
@@ -104,17 +103,6 @@ func KourierMinikube() error {
 
 	fmt.Println("    Domain DNS set up...")
 
-	// For windows and mac users, do not automatically spawn a tunnel
-	// Instead, they will be directed to create one manually after
-	// the plugin finishes
-	if runtime.GOOS != "window" && runtime.GOOS != "darwin" {
-		tunnel := exec.Command("minikube", "tunnel", "--profile", "knative")
-		if err := tunnel.Start(); err != nil {
-			return fmt.Errorf("tunnel: %w", err)
-		}
-		fmt.Println("    Minikube tunnel...")
-	}
-
 	fmt.Println("    Finished configuring Kourier")
 	return nil
 }
diff --git a/pkg/minikube/minikube.go b/pkg/minikube/minikube.go
index 89a4ca03..040e5359 100644
--- a/pkg/minikube/minikube.go
+++ b/pkg/minikube/minikube.go
@@ -19,7 +19,6 @@ import (
 	"os"
 	"os/exec"
 	"regexp"
-	"runtime"
 	"strconv"
 	"strings"
 	"time"
@@ -61,14 +60,12 @@ func SetUp(name, kVersion string, installServing, installEventing bool) error {
 	if err := createMinikubeCluster(); err != nil {
 		return fmt.Errorf("creating cluster: %w", err)
 	}
-	if runtime.GOOS == "darwin" || runtime.GOOS == "windows" {
-		fmt.Print("\n")
-		fmt.Println("To finish setting up networking for minikube, run the following command in a separate terminal window:")
-		fmt.Println("    minikube tunnel --profile knative")
-		fmt.Println("The tunnel command must be running in a terminal window any time when using the knative quickstart environment.")
-		fmt.Println("\nPress the Enter key to continue")
-		fmt.Scanln()
-	}
+	fmt.Print("\n")
+	fmt.Println("To finish setting up networking for minikube, run the following command in a separate terminal window:")
+	fmt.Println("    minikube tunnel --profile knative")
+	fmt.Println("The tunnel command must be running in a terminal window any time when using the knative quickstart environment.")
+	fmt.Println("\nPress the Enter key to continue")
+	fmt.Scanln()
 
 	if installServing {
 		if err := install.Serving(); err != nil {