Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Added kubeclient to context for new adapter creation #1406

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

Cali0707
Copy link
Member

Fixes the failing integration tests

Proposed Changes

  • Add the kubeclient into the context used to create the new adapter in the Update function

@Cali0707
Copy link
Member Author

/cc @pierDipi @creydr

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 12, 2023
@knative-prow knative-prow bot requested review from creydr and pierDipi October 12, 2023 15:40
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2023
@knative-prow knative-prow bot requested review from lberk and odacremolbap October 12, 2023 15:40
@Cali0707
Copy link
Member Author

/hold
I'll unhold when the integration tests pass

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2023
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member

/hold unhold once ready

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #1406 (7f935b1) into main (0270076) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1406      +/-   ##
==========================================
+ Coverage   68.36%   68.39%   +0.02%     
==========================================
  Files          39       39              
  Lines        2368     2370       +2     
==========================================
+ Hits         1619     1621       +2     
  Misses        670      670              
  Partials       79       79              
Files Coverage Δ
pkg/source/mtadapter/adapter.go 45.07% <100.00%> (+0.57%) ⬆️

@Cali0707
Copy link
Member Author

/unhold
All the tests passed

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2023
@knative-prow knative-prow bot merged commit 7bd87d1 into knative-extensions:main Oct 12, 2023
17 checks passed
@creydr
Copy link
Contributor

creydr commented Oct 12, 2023

Thanks for fixing @Cali0707

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants