Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epubmakerで一時フォルダが残っているときに2回目のremove_entry_secureを実行するようにする #946

Merged
merged 2 commits into from
Feb 20, 2018

Conversation

kmuto
Copy link
Owner

@kmuto kmuto commented Feb 18, 2018

#941の対応
Windowsネイティブ実装RubyのバグなのかWindowsの問題なのか、remove_entry_secureにせよ、rm_rfにせよ、一時フォルダが残ってしまうことがある。
フォルダが残っているときにもう一度実行するようにする。

@kmuto
Copy link
Owner Author

kmuto commented Feb 20, 2018

write_info_bodyのほうのREXML側が問題で、parse_streamの引数にFile.newで入れてしまうとGCが働くまでcloseされないままになってしまう模様(Windowsの場合だけ? Unixもかな)。
明示的にIO変数を作ってメソッド末尾でcloseするように対処した。

@kmuto kmuto merged commit 3d0586b into master Feb 20, 2018
@kmuto kmuto deleted the doublerm branch February 20, 2018 14:58
kmuto added a commit that referenced this pull request Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant