-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
review-index: refine TOCParser and TOCPrinter #486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
print_{book|part|chapter} are defined on TOCPrinter and other classes are inherited them.
@kmuto |
実際の利用シーンで使うことがなかったので、IDGTocのほうは削除してOKです。 |
@kmuto なんと。それではIDGTOCPrinterの方は後で消しておきます |
takahashim
added a commit
that referenced
this pull request
Feb 13, 2016
review-index: refine TOCParser and TOCPrinter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
目次周りを何とかするべく、TOCParserを大工事しています。
--html
オプションは誰も使ってない。-a
で文書全体、-p
で部単位、-c
で章単位に出力するところを、print_book, print_part, print_chapterのメソッドに切り分けて、各メソッドの実装もこれらのメソッドを使うようにしています。ruby -w
をつけて警告が出るところを一部修正しています。今のところTOCParserはreview-indexコマンドでしか使っていないはずですが、本体でも使うようにする予定です。