Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warnとerrorを整理する #1674

Closed
takahashim opened this issue Feb 21, 2021 · 5 comments · Fixed by #1694
Closed

warnとerrorを整理する #1674

takahashim opened this issue Feb 21, 2021 · 5 comments · Fixed by #1694

Comments

@takahashim
Copy link
Collaborator

いろんなところでerrorとwarnを定義しているので、もうちょっとまとめたいですね…。
@kmuto
Copy link
Owner

kmuto commented Feb 22, 2021

👍

@kmuto kmuto mentioned this issue Feb 28, 2021
Closed
7 tasks
@takahashim
Copy link
Collaborator Author

  • warn: とにかくloggerに出力する
  • error:
    • builder: 基本はCompilerから呼び出されるので、例外をあげてCompiler側で処理させる
    • compiler: @errorsか何かでエラーを保持する？ 途中では死なない。loggerに吐いて保持しておいて、最後にエラーが保持されていれば終了する？
    • maker: 終了する

@takahashim
Copy link
Collaborator Author

終了するエラーは error!(msg)とかにした方がいいかも？

@takahashim
Copy link
Collaborator Author

compileエラーについてはエラーになったファイルと行数が表示されるようにできそう

@takahashim takahashim mentioned this issue May 23, 2021
Merged
@takahashim
Copy link
Collaborator Author

takahashim commented May 24, 2021 •
edited
Loading

errorとwarnはメッセージ出力のみ、error!は終了、app_errorはApplicationErrorを上げる、に統一してみます

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

warn and error have been completely replaced. kmuto/review
2 participants
@takahashim @kmuto