Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimensional mineshafts don't allow Djinni miners #1107

Closed
theCalcaholic opened this issue Apr 10, 2024 · 3 comments
Closed

Dimensional mineshafts don't allow Djinni miners #1107

theCalcaholic opened this issue Apr 10, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@theCalcaholic
Copy link

theCalcaholic commented Apr 10, 2024

Describe the bug
So if I understand how they should work, dimensional mineshafts are broken for me in two ways:

  1. They don't produce ores. The progress bar will complete multiple times, but they won't output anything. Similar to [BUG]: Dimensional Mineshaft/Miner recipes not working. #892 but without the broken recipes in JEI/REI (and on the latest version of Occultism). Also the durability of the ore miner doesn't reduce.
  2. I cannot input the ore miners by hand, only with a hopper. When I drag a lamp into the slot, it won't allow me to drop it there, but putting a hopper on top of the mineshaft and inserting ore miners through that works.

To Reproduce
Steps to reproduce the behavior:

  1. Place dimensional mineshaft
  2. Right click and fail to insert ore miner by hand
  3. Add hopper on top and insert ore miner through that
  4. Observer no ores getting produced.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

System (please complete the following information):

  • Occultism Version: 1.124.3
  • OS: Linux (Fedora, Server: debian)
  • Minecraft Version: 1.20.1
  • Modpack Link and Version, or list of mods: Valhelsia 6 with a few manually added mods (among them occultism) - full modlist

Additional context

EDIT: I just noticed, that this behavior does only apply to Djinni miners for some reason - which are the only ones I had tried so far. Foliots, Afrits and Marids do work as expected. Am I missing something?

@theCalcaholic theCalcaholic added the bug Something isn't working label Apr 10, 2024
@theCalcaholic theCalcaholic changed the title Dimensional mineshafts are broken Dimensional mineshafts don't allow Djinni miners Apr 10, 2024
@klikli-dev
Copy link
Owner

The behaviour your describe indicates a recipe issue (I think hoppers bypass the "insert only if valid recipe" check).
Do you see any recipes for djinni miners?

@theCalcaholic
Copy link
Author

theCalcaholic commented Apr 10, 2024

@klikli-dev Interesting, I just noticed, that, according to REI, the Djinni ore miner has no tags, which sounds like it could be the issue - any idea what might cause this?

I suppose the mineshaft isn't accepting it, because it's missing the #occultism:miners/ores tag.

@GaeaKat
Copy link
Contributor

GaeaKat commented Apr 10, 2024

Looked into this, it looks like it may have been missed when I added data-gen for tags

GaeaKat added a commit to KatCodesMods/occultism that referenced this issue Apr 10, 2024
GaeaKat added a commit to KatCodesMods/occultism that referenced this issue Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants