Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS: Use standard packaging and installation approaches #4

Closed
engnadeau opened this issue Aug 1, 2021 · 2 comments
Closed

JOSS: Use standard packaging and installation approaches #4

engnadeau opened this issue Aug 1, 2021 · 2 comments

Comments

@engnadeau
Copy link

  • Using standard packaging and installation approaches helps foster external collaboration and reduces issues/errors, especially when robust tools with their own checks are leveraged (e.g., npm, yarn, make, pip)
  • This is especially important for security and SecOps, which is very strict in clinical/medical environments
  • The current installation approach has the user running untrusted scripts, downloading artifacts from external servers, modifying files/folders/paths, unzipping archives, and running powershell subprocesses
  • Many of the above steps would be flagged in a (properly) secure IT environment (e.g., powershell is often blocked on most PCs in well-maintained IT environments)
  • Moverover, there is code duplication between windows vs linux installation scripts (e.g., forward vs backslashes)
  • If standard installation or packaging tools were used, duplications and security issues would be resolved, as these tools are platform agnostic
  • Given that downloadDeps.sh appears to focus on js installation, I'd recommend a js-based package manager (e.g., npm or yarn)
  • cc [REVIEW]: Kinematics-vis: A Visualization Tool for the Mathematics of Human Motion openjournals/joss-reviews#3490
@klevis-a
Copy link
Owner

klevis-a commented Aug 3, 2021

Closing this based on our discussion in openjournals/joss-reviews#3490.

@klevis-a
Copy link
Owner

@nnadeau I actually got around to using standard packaging (yarn and webpack). See #20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants