Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types for typescript #6

Closed
j-d-carmichael opened this issue Dec 19, 2020 · 2 comments
Closed

Types for typescript #6

j-d-carmichael opened this issue Dec 19, 2020 · 2 comments
Labels
feature New feature or request released

Comments

@j-d-carmichael
Copy link

Looks way cleaner and easier to use than vue-color but cannot use as there are no types - it is this already in progress?

@kleinfreund kleinfreund added the feature New feature or request label Dec 19, 2020
@kleinfreund
Copy link
Owner

I do want to add types to the project, yes. I’m also considering to write it in TypeScript entirely but for that, I want to finish the migration to Vue.js 3 first. The migration to Vue.js 3 is currently blocked on a couple of issues documented in #4 so this will have to wait.

I’ll have a look at what I can do to expose type definitions for the project with the current major version 1.

@kleinfreund kleinfreund self-assigned this Dec 19, 2020
@kleinfreund
Copy link
Owner

I added some basic type definitions to the project in v1.1.0. Many parts of the code base were also covered with type annotations. The currently existing type definitions should be sufficient to annotate most things in relation to this plugin, but I don’t consider this work to be quite done, yet. I will see how the typing situation can be improved both in the source code and for package consumers.

@kleinfreund kleinfreund removed their assignment Dec 20, 2020
@kleinfreund kleinfreund self-assigned this Feb 19, 2022
@kleinfreund kleinfreund removed their assignment Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request released
Projects
None yet
Development

No branches or pull requests

2 participants