From 7476dee954b2824870873000c65f886da4e6d0c7 Mon Sep 17 00:00:00 2001 From: Richard Klees Date: Wed, 22 Feb 2017 11:45:12 +0100 Subject: [PATCH] added TODOs for ReportStudyProgramme and SP/IndividualPlanGUI --- .../classes/class.ilObjReportStudyProgrammeGUI.php | 3 +++ .../classes/tables/class.ilIndividualPlanGUI.php | 5 +++++ 2 files changed, 8 insertions(+) diff --git a/Customizing/global/plugins/Services/Repository/RepositoryObject/ReportStudyProgramme/classes/class.ilObjReportStudyProgrammeGUI.php b/Customizing/global/plugins/Services/Repository/RepositoryObject/ReportStudyProgramme/classes/class.ilObjReportStudyProgrammeGUI.php index 2265f78aafe4..62052803c774 100644 --- a/Customizing/global/plugins/Services/Repository/RepositoryObject/ReportStudyProgramme/classes/class.ilObjReportStudyProgrammeGUI.php +++ b/Customizing/global/plugins/Services/Repository/RepositoryObject/ReportStudyProgramme/classes/class.ilObjReportStudyProgrammeGUI.php @@ -123,7 +123,10 @@ public function showContent() require_once("Modules/StudyProgramme/classes/class.ilObjectFactoryWrapper.php"); $sp = \ilObjectFactoryWrapper::getInstanceByRefId($settings->getSPNodeRefId()); + // TODO: Use most recent assignment, not the first that accidentially is in the list. $assignments = $sp->getAssignmentsOf($this->g_user->getId()); + // TODO: Check if there are actually assignments and print an error message if + // none could be found. $assignment = $assignments[0]; require_once("Modules/StudyProgramme/classes/tables/class.ilIndividualPlanGUI.php"); diff --git a/Modules/StudyProgramme/classes/tables/class.ilIndividualPlanGUI.php b/Modules/StudyProgramme/classes/tables/class.ilIndividualPlanGUI.php index baf5b21b8415..56b6be8cce27 100644 --- a/Modules/StudyProgramme/classes/tables/class.ilIndividualPlanGUI.php +++ b/Modules/StudyProgramme/classes/tables/class.ilIndividualPlanGUI.php @@ -7,6 +7,8 @@ * * @author Stefan Hecken */ +// TODO: rename gev_va_* lang variables here (and on other files in this folder) to prg_* variables. +// TODO: check if all lang_vars are defined in global lang/ilias_de.lang class ilIndividualPlanGUI { @@ -30,6 +32,8 @@ class ilIndividualPlanGUI */ protected $isPost; + // TODO: Pass required attributes (i.e. assignment id and sp_ref_id) as args here. + // TODO: declare all attributes as docstrings. public function __construct() { global $ilCtrl, $tpl; @@ -258,6 +262,7 @@ protected function findAssignmentId() } } + // TODO: Remove this. The user could unambigously be retreived from the assignment. public function setUserId($user_id) { $this->user_id = $user_id;