From 63bd058555f97e1c4b3d121d383d9a646fb60c94 Mon Sep 17 00:00:00 2001 From: mjansen Date: Fri, 23 Aug 2024 08:46:56 +0200 Subject: [PATCH] Chatroom: Simplify creation code --- .../classes/class.ilChatroomFormFactory.php | 29 ------------------- .../classes/class.ilObjChatroomGUI.php | 4 ++- 2 files changed, 3 insertions(+), 30 deletions(-) diff --git a/components/ILIAS/Chatroom/classes/class.ilChatroomFormFactory.php b/components/ILIAS/Chatroom/classes/class.ilChatroomFormFactory.php index f030b027d7b2..ade089029d70 100755 --- a/components/ILIAS/Chatroom/classes/class.ilChatroomFormFactory.php +++ b/components/ILIAS/Chatroom/classes/class.ilChatroomFormFactory.php @@ -59,35 +59,6 @@ public static function applyValues(ilPropertyFormGUI $form, array $values): void ); } - /** - * Instantiates and returns ilPropertyFormGUI containing ilTextInputGUI - * and ilTextAreaInputGUI - * @deprecated replaced by default creation screens - */ - public function getCreationForm(): ilPropertyFormGUI - { - $form = new ilPropertyFormGUI(); - $title = new ilTextInputGUI($this->lng->txt('title'), 'title'); - $title->setRequired(true); - $form->addItem($title); - - $description = new ilTextAreaInputGUI($this->lng->txt('description'), 'desc'); - $form->addItem($description); - - return $this->addDefaultBehaviour($form); - } - - /** - * Adds 'create-save' and 'cancel' button to given $form and returns it. - */ - private function addDefaultBehaviour(ilPropertyFormGUI $form): ilPropertyFormGUI - { - $form->addCommandButton('create-save', $this->lng->txt('create')); - $form->addCommandButton('cancel', $this->lng->txt('cancel')); - - return $form; - } - private function mergeValuesTrafo(): \ILIAS\Refinery\Transformation { return $this->refinery->custom()->transformation(static fn(array $values): array => array_merge(...$values)); diff --git a/components/ILIAS/Chatroom/classes/class.ilObjChatroomGUI.php b/components/ILIAS/Chatroom/classes/class.ilObjChatroomGUI.php index 0e78252b2f1f..f45842eae6d9 100755 --- a/components/ILIAS/Chatroom/classes/class.ilObjChatroomGUI.php +++ b/components/ILIAS/Chatroom/classes/class.ilObjChatroomGUI.php @@ -310,7 +310,9 @@ protected function afterSave(ilObject $new_object): void $connector = $this->getConnector(); $response = $connector->sendCreatePrivateRoom( - $room->getRoomId(), $new_object->getOwner(), $new_object->getTitle() + $room->getRoomId(), + $new_object->getOwner(), + $new_object->getTitle() ); $this->tpl->setOnScreenMessage('success', $this->lng->txt('object_added'), true);