Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

blockchain/asm: assembly parser label fixes #779

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

ehnuje
Copy link
Contributor

@ehnuje ehnuje commented Nov 24, 2020

Proposed changes

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@aidan-kwon
Copy link
Member

Can this change make any incompatibility in Cypress?

@KimKyungup KimKyungup requested review from aidan-kwon and removed request for joowon-byun and aidan-kwon November 30, 2020 06:14
Copy link
Member

@aidan-kwon aidan-kwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is okay. However, we should check the incompatibility the change may cause.

@ehnuje
Copy link
Contributor Author

ehnuje commented Dec 2, 2020

@aidan-kwon How can we check the possibility of incompatibility in Cypress? Sync the node from the genesis?

@aidan-kwon
Copy link
Member

@aidan-kwon How can we check the possibility of incompatibility in Cypress? Sync the node from the genesis?

@ehnuje It seems that compiler doesn't affect generating a block, but I just want to make sure it really doesn't since I don't fully understand where compiler in asm package is used. How do you think about it? If you think the change is safe, we don't need to test. If not, we need to find testing methods.

Copy link
Contributor

@KimKyungup KimKyungup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, Klaytn doesn't use this code.
Geth has evm cmd using this code. But it is not included makefile.
Anyway, let's merge this.

@ehnuje ehnuje merged commit 8e56339 into klaytn:dev Dec 3, 2020
@ehnuje ehnuje deleted the 1125-geth-20210 branch December 3, 2020 05:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants