Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

webpack scrypt.js: Critical dependency: the request of a dependency is an expression #173

Closed
hspark80 opened this issue Dec 4, 2019 · 2 comments · Fixed by #184
Closed
Labels
issue/bug Issues with the code-level bugs.

Comments

@hspark80
Copy link

hspark80 commented Dec 4, 2019

Describe the bug
A warning is issued to build vue-app using 'carver-js v1.2.1'

How to reproduce

Expected behavior

Attachments
**** LOG ****
WARNING Compiled with 1 warnings
warning in ./node_modules/caver-js/packages/caver-klay/caver-klay-accounts/src/scrypt.js

Critical dependency: the request of a dependency is an expression

Environment (please complete the following information)
caver-js v1.2.1
node v10.16.3
webpack v4.40.2

  • OS and its version [windows10]

Additional context

There was the same problem with web3.js.
The problem that occurred in v1.2.1 appears to have disappeared since v1.2.2
Please check the link.
web3/web3.js#3018

@kjhman21
Copy link
Contributor

kjhman21 commented Dec 5, 2019

Thanks for the report.
It would appreciate if you make a PR to fix this using web3/web3.js@fea7a9b. :)

@jimni1222 jimni1222 added the issue/bug Issues with the code-level bugs. label Dec 17, 2019
@jimni1222
Copy link
Contributor

I closed this issue because this is resolved through #184 .
If you want to discuss about this more, please feel free to re-open :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/bug Issues with the code-level bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants