Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KGA-25] [KGA-73] fix: set code_address of the deployment code to the created address #1587

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

obatirou
Copy link
Collaborator

@obatirou obatirou commented Nov 7, 2024

https://github.com/code-423n4/2024-09-kakarot-findings/issues/44

What is the new behavior?

Set code_address of the deployment code to the created address.
src/ethereum/cancun/utils/message.py


This change is Reviewable

Copy link

@enitrat
Copy link
Collaborator

enitrat commented Nov 7, 2024

@obatirou you also need to do that for deploy transactions

assert code_address = new model.Address(starknet=0, evm=0);

@obatirou
Copy link
Collaborator Author

obatirou commented Nov 7, 2024

@obatirou you also need to do that for deploy transactions

assert code_address = new model.Address(starknet=0, evm=0);

Done with 7679dcd

@ClementWalter ClementWalter merged commit b2f53ba into kkrt-labs:main Nov 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants