Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev(scripts): deploy default DualVM tokens #1499

Merged
merged 20 commits into from
Nov 7, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Oct 11, 2024

  • Deploys DualVM tokens for all Starkgate-bridged token addresses, mirroring the underlying starknet token.
  • Skips deployment if the l2_token_address is the same as Kakarot's native token.

This change is Reviewable

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.5%. Comparing base (d5932d4) to head (57b287c).
Report is 7 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1499   +/-   ##
=====================================
  Coverage   63.4%   63.5%           
=====================================
  Files         44      44           
  Lines       8350    8366   +16     
=====================================
+ Hits        5298    5314   +16     
  Misses      3052    3052           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enitrat enitrat marked this pull request as draft October 11, 2024 18:02
@enitrat enitrat force-pushed the dev/deploy-dual-vm-tokens branch 2 times, most recently from f2f8845 to ce12882 Compare October 22, 2024 08:57
@enitrat enitrat marked this pull request as ready for review November 1, 2024 03:11
@enitrat enitrat force-pushed the dev/deploy-dual-vm-tokens branch 2 times, most recently from 8f21330 to 0986d4f Compare November 5, 2024 07:54
@ClementWalter ClementWalter merged commit 3b4553f into main Nov 7, 2024
16 checks passed
@ClementWalter ClementWalter deleted the dev/deploy-dual-vm-tokens branch November 7, 2024 09:52
matthieuauger pushed a commit to matthieuauger/kakarot that referenced this pull request Nov 9, 2024
* add kakarot address in Constant

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants