Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rlp encode unsigned for legacy tx #1462

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

ClementWalter
Copy link
Member

@ClementWalter ClementWalter commented Oct 2, 2024

Time spent on this PR:

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Data is not parsed and can lead to unexpected behavior.

What is the new behavior?

Added some basic parsing, I wanted initially to define proper models and use execution specs models, but it appears to be
overkill for now.


This change is Reviewable

@ClementWalter ClementWalter merged commit 8ca25c1 into kkrt-labs:main Oct 3, 2024
8 checks passed
matthieuauger pushed a commit to matthieuauger/kakarot that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants