-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix routes #29
fix routes #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Can you rebase:)? |
rebased |
Have you tried locally again if the links work? |
Update: I notice that in the current state of www.kakarot.org and docs.kakarot.org the links work properly |
youre right, I noticed the issue when it still had the bug is that every time a user clicks the direct link, it adds child url instead of goin directly to the page. testing.mp4 |
What is the difference? |
sorry I didn't make a testing video while there was still before:
this pull request:
|
But now if you've rebased it should be: localhost and not localhost/quick-start/ right? |
yes 💯 |
Thanks for the explanation 🙏. I'll close the PR for now; note this has been very helpful in finding a problem in the kakarot.org website button link so thank you. |
to fix this::
route_bug.mp4