Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix routes #29

Closed
wants to merge 1 commit into from
Closed

Conversation

naufalkharits
Copy link

to fix this::

route_bug.mp4

Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eikix
Copy link
Member

Eikix commented May 27, 2024

Can you rebase:)?

@naufalkharits
Copy link
Author

Can you rebase:)?

rebased

@Eikix
Copy link
Member

Eikix commented May 27, 2024

Have you tried locally again if the links work?
I made a change that deleted the landing page for the docs

@Eikix
Copy link
Member

Eikix commented May 27, 2024

Update: I notice that in the current state of www.kakarot.org and docs.kakarot.org the links work properly
That being said, your video allowed me to debug the kakarot.org website, since the "Explore Docs" button redirected to the wrong URL after I replaced the landing page by the quick start

@naufalkharits
Copy link
Author

youre right, I noticed the issue when it still had quick-start/.
tested it again, this change shouldn't be needed anymore.

the bug is that every time a user clicks the direct link, it adds child url instead of goin directly to the page.

testing.mp4

@Eikix
Copy link
Member

Eikix commented May 27, 2024

youre right, I noticed the issue when it still had quick-start/. tested it again, this change shouldn't be needed anymore.

the bug is that every time a user clicks the direct link, it adds child url instead of goin directly to the page.

testing.mp4

What is the difference?

@naufalkharits
Copy link
Author

sorry I didn't make a testing video while there was still quick-start/.
I'll explain in plain text, hope you would get it.

before:

  • localhost/quick-startsurvival-guide ✅ works perfectly
  • localhost/quick-start/survival-guide ❌ it will adds child url

this pull request:

  • localhost/quick-start/survival-guide ✅ works perfectly
  • localhost/quick-start//survival-guide ✅ works perfectly

@Eikix
Copy link
Member

Eikix commented May 27, 2024

sorry I didn't make a testing video while there was still quick-start/. I'll explain in plain text, hope you would get it.

before:

  • localhost/quick-startsurvival-guide ✅ works perfectly
  • localhost/quick-start/survival-guide ❌ it will adds child url

this pull request:

  • localhost/quick-start/survival-guide ✅ works perfectly
  • localhost/quick-start//survival-guide ✅ works perfectly

But now if you've rebased it should be:

localhost and not localhost/quick-start/ right?

@naufalkharits
Copy link
Author

naufalkharits commented May 27, 2024

youre right, I noticed the issue when it still had quick-start/. tested it again, this change shouldn't be needed anymore.

the bug is that every time a user clicks the direct link, it adds child url instead of goin directly to the page.

testing.mp4

yes 💯
As I said above, this pull request may not be needed anymore, assuming the docs web remain without a child url not like before had a child url(quick-start/).

@Eikix
Copy link
Member

Eikix commented May 27, 2024

youre right, I noticed the issue when it still had quick-start/. tested it again, this change shouldn't be needed anymore.
the bug is that every time a user clicks the direct link, it adds child url instead of goin directly to the page.
testing.mp4

yes 💯 As I said above, this pull request may not be needed anymore, assuming the docs web remain without a child url not like before had a child url(quick-start/).

Thanks for the explanation 🙏. I'll close the PR for now; note this has been very helpful in finding a problem in the kakarot.org website button link so thank you.
I hope to see more PRs from you on our repos:)

@Eikix Eikix closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants