add examples #37
Open
add examples #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @kkemple thanks for your work, but, this repo still working? |
|
hi @kkemple could you please send the link of the players example? thx |
|
this looks great and I can merge if still working, @geminiyellow I haven't been maintaining this since im no longer working in RN but have been looking for maintainers. No one wants to so it sits. |
|
opps @kkemple , thanks for your reply. i m no longer working in RN, too. LOL. |
|
Hey, guys! How to fix a bug as you can see below, the issue is when you touch card rapidly it is not so smoothly like a native behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you do:
Added examples as suggested in #31, this closes #31.
The following three were added in an
examplesfolder, shamlessly copied from your provided snack examples:sideswipedfrom https://snack.expo.io/@kkemple/sideswipe-exampleCarousel, AnimatedCarouselItemto the newerSideSwipeAPIpokedexfrom https://snack.expo.io/@kkemple/pokedexspacedfrom https://snack.expo.io/@kkemple/spaced-sideswipeTested all three successfully locally in an iOS and Android expo client.
I also added the examples folder to
.npmignorefor smaller user node_modules. This could be easily reverted, if you prefer to publish the examples along.Does this relate to any issue(s)? If so which one(s)?
#31
Checklist:
yarn lintandyarn flow