Skip to content

Commit

Permalink
src: reuse std::make_unique
Browse files Browse the repository at this point in the history
Ref: nodejs@283a967

PR-URL: nodejs#24132
Refs: nodejs@283a967
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
  • Loading branch information
alyssaq authored and kiyomizumia committed Nov 15, 2018
1 parent eea69b4 commit 6f4959c
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions src/inspector_agent.cc
Original file line number Diff line number Diff line change
Expand Up @@ -475,11 +475,9 @@ class NodeInspectorClient : public V8InspectorClient {
bool prevent_shutdown) {
events_dispatched_ = true;
int session_id = next_session_id_++;
// TODO(addaleax): Revert back to using make_unique once we get issues
// with CI resolved (i.e. revert the patch that added this comment).
channels_[session_id].reset(
new ChannelImpl(env_, client_, getWorkerManager(),
std::move(delegate), prevent_shutdown));
channels_[session_id] =
std::make_unique<ChannelImpl>(env_, client_, getWorkerManager(),
std::move(delegate), prevent_shutdown);
return session_id;
}

Expand Down

0 comments on commit 6f4959c

Please sign in to comment.