-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kiwix-Serve does not support Multipart-range HTTP requests #855
Comments
This limitation was documented in #360:
@kelson42 Do you know what happens in response to our 416 response to such a multi-part range request?
I believe that for scenario 1, we shouldn't waste any effort implementing this enhancement. |
I don't know how browsers react to this, probably they just stop because the spec is not fully implemented, which is not an allowed scenario (either you support byte ranges or not). |
@kelson42 Can't we find out a fact based answer from library.kiwix.org logs? |
@rgaudin ? |
That sounds difficult but the 416 requests were:
Now I have about 800 lines of logs spread across 2 IPs. I removed the IPs and there is apparently no suggest nor content search request so I guess it's fine to share here. |
416-user2.log Doesn't contain any 416 responses. Looking at 416-user.log, I see that a request to
This pattern repeats another time:
However, it is not clear if for the 416 responses we deal with multi-part range requests (it could rather be, for example, an out-of-bounds single-range request). Yet it is strange that a web client sends a range request for an illustration resource. @kelson42 What made you think that the 416 responses from library.kiwix.org are caused by multi-part range requests? |
Concretly nothing I can remember, but what would be another plausible scenario? |
Interesting reading https://www.zeng.dev/post/2023-http-range-and-play-mp4-in-browser/ |
If such a request is done with latest version
3.4.0
, then an error is returned:Unfortunately, the analysis of library.kiwix.org logs has shown that we have legitimate clients (Chrome on Android) which generate such kind of requests.
Therefore, this part of the specification like explained here should be supported:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Range_requests#multipart_ranges
Kind of follow-up of #363
The text was updated successfully, but these errors were encountered: