Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algorithm that notifies users that a new GitHub update of Wikivoyage is available thinks 3.3.6 > 3.3.10 #631

Open
Jaifroid opened this issue Aug 5, 2024 · 2 comments

Comments

@Jaifroid
Copy link
Member

Jaifroid commented Aug 5, 2024

This means users will be incorrectly notified that there is an update (fortunately it's a silent but quite visible notification at the top of Configuration) that there is an "update" version 3.3.6, when in fact that is the previous version.

Clearly it is doing an arithmetic "greater than" instead of a semantic "greater than". Grrr.

I can probably fix this by deleting or unpublishing (for now) v3.3.6, as I can't now update the code of 3.3.10 (which is released).

Either I avoid releasing versions with minorVersion > 9, or else I fix the algorithm to use a semantic comparison (I'm sure I have a bit of code somewhere in the app that has the required logic already, it's just not in the Electron update part). A fix would be better, if that code is under my control (I believe it is).

@Jaifroid
Copy link
Member Author

Jaifroid commented Aug 5, 2024

There is no unpublish (convert to draft) for releases. So, I can either change the tag to 3.2.10, which will probably introduce some other weirdness with an out-of-sequence tag, or else I can just delete the previous release once the winget repository is updated to the latest (it's in certification).

@Jaifroid
Copy link
Member Author

Jaifroid commented Aug 6, 2024

I confirm that deleting the previous release 3.3.6 prevents the update notification from appearing in 3.3.10. This is merely a workaround.

@Jaifroid Jaifroid modified the milestones: Release 3.4.0, Release 3.5.0 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant