Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build libkiwix wasm #557

Open
kelson42 opened this issue Dec 11, 2022 · 5 comments
Open

Build libkiwix wasm #557

kelson42 opened this issue Dec 11, 2022 · 5 comments

Comments

@kelson42
Copy link
Contributor

I think this could be really useful for our jacascript ports.

@kelson42
Copy link
Contributor Author

@mgautierfr @Jaifroid Any opinion?

@Jaifroid
Copy link
Member

I'm a bit hazy as to what libkiwix does, as opposed to libzim...

I'm having some difficulties using the libzim in practice, the most serious of which is a memory leak (openzim/javascript-libzim#34)... Therefore, if libkiwix is a superset of libzim, then I think we should probably focus on making libzim robust first. If that can be solved, we'll have the know-how for more ambitious things.

@mgautierfr
Copy link
Member

I'm not sure it is needed.
Libkiwix now is more focused on the "management" of zim files (downloading, library handling, server)
I don't know if it is needed in our javascript port.
Everything about creating/reading/searching in zim itself is in libzim.

@kelson42
Copy link
Contributor Author

@mgautierfr Could you please just update https://github.com/kiwix/libkiwix README.md to give a bullet point driven list of domains where the libkiwix delivers. I have in my mind:

  • Bookmark mgmt
  • Local/Online library mgmt
  • ZIM Download mgmt (via aria2c)
  • HTTP daemon

Anything else?

@kelson42
Copy link
Contributor Author

Therefore, if libkiwix is a superset of libzim, then I think we should probably focus on making libzim robust first.

Libkiwix does not superseed (anymore) the libzim. It's complementary.

Indeed, if libzim wasm integration is not a success then it will be worthless to implement this ticket. This should indeed be validated first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants