-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of libkiwix14 #984
Comments
@BPerlakiH Can you please make a draft PR and check that everything is OK before the libkiwix 14 release (using nightly)? |
@kelson42 from the errors on the PR it seems to me that the iOS simulator is not included in the target framework build of libkiwix. Also it is substantially smaller than the former package here (13.1.0 vs 14.0.0):
I think it needs a re-build. |
@rgaudin The explanation of @BPerlakiH seems the most logical... but not clear where is the regression. We should not have touch that part, but I suspect that somehow a something has been broken. Could you please have a look please? |
@rgaudin Can we easily have a look to latest working and see where is the difference? |
Kind of suspect the regression is around libcurl... and this commit might be interesting kiwix/kiwix-build@23a6b93 |
This is fixed at kiwix/kiwix-build#765. Once @kelson42 merges it and we have a nightly, we'll be able to test. It will require adding |
@BPerlakiH yes that was expected but since the nightly workflow ran so I tested with https://download.kiwix.org/nightly/2024-10-18/libkiwix_xcframework-2024-10-18.tar.gz but that didn't work. On a second thought, that's normal as the fix was not in libkiwix (which |
Libkiwix 14 is almost over, we should use it when released.
Blocked by kiwix/libkiwix#1081
The text was updated successfully, but these errors were encountered: