diff --git a/src/main/java/org/kiwiproject/dropwizard/util/startup/PortAssigner.java b/src/main/java/org/kiwiproject/dropwizard/util/startup/PortAssigner.java index ba968e4a..7ee477d6 100644 --- a/src/main/java/org/kiwiproject/dropwizard/util/startup/PortAssigner.java +++ b/src/main/java/org/kiwiproject/dropwizard/util/startup/PortAssigner.java @@ -73,12 +73,22 @@ private PortAssigner(LocalPortChecker localPortChecker, } /** - * Sets up the connectors with a dynamic available port if {@link PortAssigner} is configured for dynamic ports. - * - * @implNote When using {@link PortSecurity#SECURE}, the current implementation replaces the + * Sets up the application and admin connectors with a dynamic available port + * if {@link PortAssigner} is configured for dynamic ports. + *

+ * When using {@link PortSecurity#NON_SECURE HTTP}, + * only the first application and admin connectors have dynamic ports assigned. + * If an application is using multiple connectors, it's best to avoid using this class + * unless you only want the first ones dynamically assigned. + *

+ * When using {@link PortSecurity#SECURE HTTPS}, the current implementation replaces the * application and admin connector factories, which overrides any explicit configuration. * Support for explicit configuration of secure connectors while still assigning dynamics ports may * be implemented in the future if custom configuration is needed. + *

+ * WARNING: If you need to change specific properties of secure ports, + * or need more than one secure application and/or admin port, you can't use this + * class, since it will replace all other ports! */ public void assignDynamicPorts() { if (portAssignment == PortAssignment.STATIC) { @@ -94,7 +104,7 @@ public void assignDynamicPorts() { } private void assignSecureDynamicPorts() { - LOG.debug("Secure (https): replace Dropwizard HTTP app/admin connectors with HTTPS ones using dynamic ports"); + LOG.debug("Secure (https): *replace* Dropwizard HTTP app/admin connectors with HTTPS ones using dynamic ports"); var usedPorts = new HashSet(); diff --git a/src/test/java/org/kiwiproject/dropwizard/util/resource/ConfigResourceTest.java b/src/test/java/org/kiwiproject/dropwizard/util/resource/ConfigResourceTest.java index cae69279..7f781d0a 100644 --- a/src/test/java/org/kiwiproject/dropwizard/util/resource/ConfigResourceTest.java +++ b/src/test/java/org/kiwiproject/dropwizard/util/resource/ConfigResourceTest.java @@ -40,7 +40,7 @@ class ConfigResourceTest { @Getter @Setter @AllArgsConstructor - static class TestConfig extends Configuration { + public static class TestConfig extends Configuration { private String someNeededProperty; private String someHiddenPassword; private CacheConfig cacheConfig;