Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Text: use custom font #307

Closed
mrtnzlml opened this issue Feb 28, 2018 · 4 comments · Fixed by #347
Closed

Text: use custom font #307

mrtnzlml opened this issue Feb 28, 2018 · 4 comments · Fixed by #347
Assignees
@tbergquist-godaddy

Comments

@mrtnzlml
Copy link
Contributor

mrtnzlml commented Feb 28, 2018 •
edited
Loading

We need to distribute our own font to prevent these issues on weird devices: facebook/react-native#15114

System fonts:

  • iOS: SanFran
  • Android: Roboto

Related issue: https://trello.com/c/sYuG1zzB/159-bug-uncompleted-strings-and-layouts-in-hotels
@tbergquist-godaddy
Copy link
Contributor

@mrtnzlml this is just relevant for android right?

@mrtnzlml
Copy link
Contributor Author

mrtnzlml commented Mar 8, 2018

@tbergq Probably yes.

@tbergquist-godaddy
Copy link
Contributor

Did a quick check on the kiwi app, deployment target is iOS 9, and font has been SanFran since iOS 9, i will leave the system fonts for iOS

@mrtnzlml
Copy link
Contributor Author

mrtnzlml commented Mar 8, 2018

@tbergq OK, it's reported only on weird Android devices. They use a custom font instead of Roboto and RN is not happy with this font for some reason.

@tbergquist-godaddy tbergquist-godaddy mentioned this issue Mar 8, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tbergquist-godaddy tbergquist-godaddy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add roboto font kiwicom/mobile
2 participants
@mrtnzlml @tbergquist-godaddy