From da1c8ca54b5b7b165737a288282853443ca34eb9 Mon Sep 17 00:00:00 2001 From: Mirko Galimberti Date: Sun, 9 Oct 2022 18:03:53 +0200 Subject: [PATCH] Update MIN_TARGET_API and RECOMMENDED_TARGET_API --- pythonforandroid/recommendations.py | 6 +++--- tests/test_recommendations.py | 2 +- tests/test_toolchain.py | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pythonforandroid/recommendations.py b/pythonforandroid/recommendations.py index a8b2f81a59..040c96234a 100644 --- a/pythonforandroid/recommendations.py +++ b/pythonforandroid/recommendations.py @@ -135,15 +135,15 @@ def read_ndk_version(ndk_dir): return ndk_version -MIN_TARGET_API = 26 +MIN_TARGET_API = 30 # highest version tested to work fine with SDL2 # should be a good default for other bootstraps too -RECOMMENDED_TARGET_API = 27 +RECOMMENDED_TARGET_API = 33 ARMEABI_MAX_TARGET_API = 21 OLD_API_MESSAGE = ( - 'Target APIs lower than 26 are no longer supported on Google Play, ' + 'Target APIs lower than 30 are no longer supported on Google Play, ' 'and are not recommended. Note that the Target API can be higher than ' 'your device Android version, and should usually be as high as possible.') diff --git a/tests/test_recommendations.py b/tests/test_recommendations.py index 3e9db9fe9e..df68bbe3e0 100644 --- a/tests/test_recommendations.py +++ b/tests/test_recommendations.py @@ -163,7 +163,7 @@ def test_check_target_api_warning_target_api(self): self.assertEqual( cm.output, [ - "WARNING:p4a:[WARNING]: Target API 25 < 26", + "WARNING:p4a:[WARNING]: Target API 29 < 30", "WARNING:p4a:[WARNING]: {old_api_msg}".format( old_api_msg=OLD_API_MESSAGE ), diff --git a/tests/test_toolchain.py b/tests/test_toolchain.py index 0cc2b1a7f5..874453f981 100644 --- a/tests/test_toolchain.py +++ b/tests/test_toolchain.py @@ -74,7 +74,7 @@ def test_create(self): 'pythonforandroid.bootstraps.service_only.' 'ServiceOnlyBootstrap.assemble_distribution' ) as m_run_distribute: - m_get_available_apis.return_value = [27] + m_get_available_apis.return_value = [33] tchain = ToolchainCL() assert tchain.ctx.activity_class_name == 'abc.myapp.android.CustomPythonActivity' assert tchain.ctx.service_class_name == 'xyz.myapp.android.CustomPythonService'