Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unintended rollback patches #632

Closed
brussee opened this issue Feb 9, 2016 · 5 comments
Closed

Unintended rollback patches #632

brussee opened this issue Feb 9, 2016 · 5 comments

Comments

@brussee
Copy link
Contributor

brussee commented Feb 9, 2016

Applying a patch from a recipe with

self.apply_patch(join(self.get_recipe_dir(), 'use-soname.patch'), arch.arch)

Results every other build in an unintended rollback:

Reversed (or previously applied) patch detected!  Assuming -R.
@inclement
Copy link
Member

Currently you should manually track whether the patch has already been applied, or use the patches attribute of the recipe to set the patches (in which case this is done, and the patches applied, automatically). If any existing recipe doesn't do this (are you looking at openssl?), it's a bug.

@kived
Copy link
Contributor

kived commented Feb 9, 2016

The patch in the openssl recipe is applied to files generated by the Configure script, which is why it runs unconditionally. Any patches applied via the patches class attribute are tracked and will only be applied once.

@brussee
Copy link
Contributor Author

brussee commented Feb 9, 2016

The patches can only be applied after a certain step in the recipe. When exactly are the patches = [] applied?

Yes, as a matter of fact I took the openssl recipe as an example.

@kived
Copy link
Contributor

kived commented Feb 9, 2016

They are applied directly following prebuild_arch.

@brussee
Copy link
Contributor Author

brussee commented Feb 9, 2016

The patches can only be applied after a certain step in the recipe.

Actually, the patches that are affected by the rollback can and should go in the patches = [].
Thanks!

@brussee brussee closed this as completed Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants