Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non full screen touch offset on android #153

Closed
eulerreich opened this issue Aug 29, 2013 · 3 comments
Closed

non full screen touch offset on android #153

eulerreich opened this issue Aug 29, 2013 · 3 comments

Comments

@eulerreich
Copy link

When running kivy apps without full screen on, the touch received by the app seems to be many pixels higher than the actual touch location. This phenomenon doesn't occur when full screen is on.

Inclement suggested that this is a p4a bug introduced recently.

@denspb
Copy link

denspb commented Aug 30, 2013

Confirm this behavior on Samsung GT-I9100.
It seems that touch events does not include "offset" of the notification area.

@inclement
Copy link
Member

As eulerreich says, I also see this behaviour.

I remember a very similar bug a few months ago when I started using kivy, which was related to not including the notification area, and was fixed with the commit at 9eddd5e . No other commit seems to have affected the relevant parts of the file since then, so I don't know why the behaviour has resurfaced...assuming it is indeed the notification bar width that's the problem.

Edit: I tried manually reverting to the state a few weeks ago, but I still seem to have the touch offset...so I don't really know what's going on. Maybe I just did something wrong...

@inclement
Copy link
Member

I'm pretty sure I've tracked down the bug to the commit at bc4a45c , but I really don't know about this part of the code. Can anyone confirm this is the one (I originally checked out commits through the last few weeks until I narrowed it down, but just reverting this single commit in master seems to fix the bug)?

Assuming I'm right...anyone know the right way to fix it? I assume the commit was for a reason in the first place, so just reverting it wouldn't be ideal.

Edit: And unless I'm very much mistaken, reverting the original touch fix (9eddd5e) also fixes the current bug. Perhaps the non-overridden dispatchTouchEvent method already performs the navigation bar height adjustment, leading to a double-fix after both commits that creates the bug again? On the other hand, I might be very much mistaken, can anyone confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants