-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vibrator for android v < 4.0 #129
Conversation
@@ -1,11 +1,7 @@ | |||
|
|||
"""Plyer Vibrator Example.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple, one-line docstrings like this don't add any information and should be avoided. (We know this is a Plyer Vibrator Example, because it's examples/vibrator/main.py in Plyer. Similarly we know that VibrationApp is the Main Application, and that build() returns the root widget, etc., without needing docstrings.) Also, remember to follow our standards (look at the rest of the code). We use ''''''
for docstrings, not """"""
.
sync pull request
def _exists(self): | ||
if SDK_INT >= 11: | ||
return vibrator.hasVibrator() | ||
return NotImplementedError() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review this line.
👍 |
Feature
exists
is supported only for android SDK >= 11. Rest features work.Tested on Samsung Galaxy I, android 2.3.
What we should do? Does we need new Exception
NotSupported
or just returnNone
Currently it returns None if SDK < 11
best regards