Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large number of dependencies #2

Closed
stefnotch opened this issue Dec 17, 2023 · 5 comments
Closed

Large number of dependencies #2

stefnotch opened this issue Dec 17, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@stefnotch
Copy link

I installed this, and npm said added 57 packages, and audited 188 packages in 16s
Adding 57 packages seems like a lot to me.

I took a short peek at the package.json, and noticed the bumpp dependency. Could this dependency potentially be turned into a dev dependency?
https://github.com/kitschpatrol/svelte-tweakpane-ui/blob/a0e9d75642ea960302c5a92aad5219ba5c8afea4/package.json#L228C5-L228C11

@kitschpatrol
Copy link
Owner

Thanks for opening this — and oops yes thank you, I will move bumpp to dev dependencies in the next release, that was a mistake.

In general, a design priority for the library is a "batteries included" approach for ease of development — bundling Tweakpane plugins, in particular, comes at the expense of some extra dependencies during development. My sense is that they're not a burden to the end-user since they can be tree-shaken away in the production build.

The only other non-essential direct dependencies that I can see are esm-env, and nanoid... both of which are pretty light and have zero dependencies of their own.

(Also, I'd definitely recommend against adding up the dev dependencies. 🫣😅.)

@stefnotch
Copy link
Author

Awesome, that sounds perfect then.

@kitschpatrol
Copy link
Owner

kitschpatrol commented Dec 18, 2023

Fix has been released in version 1.1.0.

@stefnotch
Copy link
Author

Thank you so much for this super fast improvement.

Time to continue absolutely enjoying this little library.

@kitschpatrol
Copy link
Owner

I'm going to track work on reducing the final bundle size in issue #6.

@kitschpatrol kitschpatrol self-assigned this May 15, 2024
@kitschpatrol kitschpatrol added the bug Something isn't working label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants