Fix test errors with creating route methods #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleek91
commented
Dec 31, 2023
There was a problem hiding this comment.
I think using ts comments is going to be necessary in type files especially to test negatives. So I don't think we need to link for them in spec files.
pleek91
commented
Dec 31, 2023
There was a problem hiding this comment.
Typescript sees that isPublic could be false so the type so it complains. Probably some type guarding we could do but didn't seem worth introducing for these tests.
pleek91
commented
Dec 31, 2023
There was a problem hiding this comment.
This makes sure we don't add empty objects for leaves that are not callable.
stackoverfloweth
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
never#36