Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Value in key-value in header should not be heading #3766

Open
1 of 11 tasks
RasmusKjeldgaard opened this issue Jan 24, 2025 · 0 comments
Open
1 of 11 tasks
Labels
accessibility enhancement New feature or request

Comments

@RasmusKjeldgaard
Copy link
Collaborator

Describe the enhancement

The value of the header is currently a h3, but should most likely not be a heading at all, as it will show up when navigating the page by headings, for example in the VoiceOver rotor.

VO-rotor-header-value.mov

Describe the solution you'd like

Possibly just render as a span or paragraph tag by default, since a h1 is already present via the key/title?


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@RasmusKjeldgaard RasmusKjeldgaard added enhancement New feature or request NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed 👶🏻 New For new issues before prioritisation and refinement labels Jan 24, 2025
@github-project-automation github-project-automation bot moved this to 💌 Inbox in Kirby Jan 24, 2025
@RasmusKjeldgaard RasmusKjeldgaard added accessibility and removed NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility enhancement New feature or request
Projects
Status: 💌 Inbox
Development

No branches or pull requests

1 participant