Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Fixed toolbar title in page should be heading (h1) #3748

Open
1 of 11 tasks
RasmusKjeldgaard opened this issue Jan 8, 2025 · 0 comments
Open
1 of 11 tasks
Labels
accessibility enhancement New feature or request 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed

Comments

@RasmusKjeldgaard
Copy link
Collaborator

Describe the enhancement

With only a toolbarTitle, and no title, on a Kirby Page, the title becomes fixed in the toolbar.
The scenario in question can be seen here: https://cookbook.kirby.design/#/examples/page/fixed

Describe the solution you'd like

In the fixe state, the toolbar title should act as the page title and be marked up as a h1 for proper semantics.

Are there any additional context?

Current workaround is to use the *kirbyPageToolbarTitle directive on a h1 with a little bit of custom styling to make it look similar to the default fixed toolbarTitle.


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@RasmusKjeldgaard RasmusKjeldgaard added enhancement New feature or request NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone accessibility 👶🏻 New For new issues before prioritisation and refinement labels Jan 8, 2025
@github-project-automation github-project-automation bot moved this to 💌 Inbox in Kirby Jan 8, 2025
@RasmusKjeldgaard RasmusKjeldgaard moved this from 💌 Inbox to ⭐ Planned Work in Kirby Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility enhancement New feature or request 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed
Projects
Status: ⭐ Planned Work
Development

No branches or pull requests

1 participant