Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing blue outline of selectable focused item when navigating by keyboard #3733

Open
8 tasks
Fuzzy3 opened this issue Dec 6, 2024 · 0 comments
Open
8 tasks
Labels
bug 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild

Comments

@Fuzzy3
Copy link
Collaborator

Fuzzy3 commented Dec 6, 2024

Describe the bug

When navigating by keyboard and focus lands on a selectable item, the focused item has poor visual indication that it is currently selected. The focused item should have a blue outline like our kirby-buttons, since the selectable item acts like a button.

Describe how to reproduce the bug

  1. Go to the cookbook item page
  2. Tab through the page until a selectable item gets focus
  3. Watch how the item is dimmed to the same grey as the page background indicating that it received focus. Also watch how it is missing a clearer visual indication that it currently has the focus.

What was the expected behavior?

Selectable items should have a blue outline similar to buttons.

Add any screenshots

First item has focus in the first screenshot.
image
image

Please complete the following information:

  • OS: [e.g. Windows, MacOS, iOS]
  • Browser [e.g. Chrome, Safari]
  • Browser version [e.g. 22]

Are there any additional context?

When approaching this issue - make sure that it is also working for items in a menu.


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Verification

To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.

  • Make sure the NOT verified label has been removed by a member of team Kirby; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

Review

Once the issue has been implemented and is ready for review:

@Fuzzy3 Fuzzy3 added bug NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild labels Dec 6, 2024
@github-project-automation github-project-automation bot moved this to 💌 Inbox in Kirby Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild
Projects
Status: 💌 Inbox
Development

No branches or pull requests

1 participant