Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing space between toggle and its slotted content when slot="end" in item #3732

Open
8 tasks
Fuzzy3 opened this issue Dec 6, 2024 · 0 comments · Fixed by #3738 · May be fixed by #3739
Open
8 tasks

[BUG] Missing space between toggle and its slotted content when slot="end" in item #3732

Fuzzy3 opened this issue Dec 6, 2024 · 0 comments · Fixed by #3738 · May be fixed by #3739
Assignees
Labels

Comments

@Fuzzy3
Copy link
Collaborator

Fuzzy3 commented Dec 6, 2024

Describe the bug

When adding content to a toggle in the end-slot of an item, the content is not left-aligned since the toggle and content is missing space between. Similar functionality is implemented for the checkbox component.

Describe how to reproduce the bug

Add a kirby-item with a kirby-toggle in the end-slot which has a kirby label in it:

<kirby-item>
  <kirby-icon name="default" slot="start"></kirby-icon>
  <kirby-toggle slot="end">
    <kirby-label>      
      Allow Cheats
    </kirby-label>
  </kirby-toggle>
</kirby-item>

See the screenshot how the label is not left-aligned like the label of the checkbox.

Add any screenshots

image

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Verification

To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.

  • Make sure the NOT verified label has been removed by a member of team Kirby; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

Review

Once the issue has been implemented and is ready for review:

@Fuzzy3 Fuzzy3 added bug NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild labels Dec 6, 2024
@github-project-automation github-project-automation bot moved this to 💌 Inbox in Kirby Dec 6, 2024
@Fuzzy3 Fuzzy3 self-assigned this Dec 6, 2024
@Fuzzy3 Fuzzy3 moved this from 💌 Inbox to 🚀 In Progress in Kirby Dec 6, 2024
@Fuzzy3 Fuzzy3 removed the NOT Prioritized Issue not yet prioritized and added to a Milestone label Dec 6, 2024
@Fuzzy3 Fuzzy3 linked a pull request Dec 11, 2024 that will close this issue
8 tasks
@github-project-automation github-project-automation bot moved this from 🚀 In Progress to ✅ Done in Kirby Dec 12, 2024
@Fuzzy3 Fuzzy3 moved this from ✅ Done to 🚀 In Progress in Kirby Dec 12, 2024
@Fuzzy3 Fuzzy3 reopened this Dec 12, 2024
@Fuzzy3 Fuzzy3 moved this from 🚀 In Progress to 🔎 Review Pending in Kirby Jan 15, 2025
@alxzak alxzak moved this from 🔎 Review Pending to 👀 Review In Progress in Kirby Jan 20, 2025
@RasmusKjeldgaard RasmusKjeldgaard removed 👶🏻 New For new issues before prioritisation and refinement NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 👀 Review In Progress
2 participants