Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Item: better handling of disabled #3720

Open
2 of 13 tasks
Tracked by #3678
jakobe opened this issue Nov 22, 2024 · 0 comments
Open
2 of 13 tasks
Tracked by #3678

[Enhancement] Item: better handling of disabled #3720

jakobe opened this issue Nov 22, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request NOT Tech refined Needs Tech kickoff - solution outlined and agreed

Comments

@jakobe
Copy link
Collaborator

jakobe commented Nov 22, 2024

Describe the enhancement

  • replace attribute binding [attr.disabled] on ion-item with a property binding on the disabled prop.
    When setting disabled="false" on kirby-item the attribute binding ends up rendering the attribute as disabled="false" but the presence of the attribute marks the element as disabled. Ionic already renders this attribute properly on the native html button inside the shadow dom
  • consider if nested interactive elements (checkbox, radio, toggle) should be disabled when the item is disabled?

Describe the solution you'd like

Have you considered any alternatives?

Are there any additional context?


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@jakobe jakobe added enhancement New feature or request NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Nov 22, 2024
@github-project-automation github-project-automation bot moved this to 📙 Backlog in Kirby Nov 22, 2024
@RasmusKjeldgaard RasmusKjeldgaard moved this from ⭐ Planned Work to 💌 Inbox in Kirby Nov 27, 2024
@RasmusKjeldgaard RasmusKjeldgaard moved this from 💌 Inbox to ⭐ Planned Work in Kirby Nov 27, 2024
@alxzak alxzak moved this from ⭐ Planned Work to 📙 Backlog in Kirby Nov 28, 2024
@alxzak alxzak moved this from 📙 Backlog to 💌 Inbox in Kirby Nov 28, 2024
@RasmusKjeldgaard RasmusKjeldgaard moved this from 💌 Inbox to ⭐ Planned Work in Kirby Nov 28, 2024
@jakobe jakobe self-assigned this Dec 13, 2024
@jakobe jakobe removed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Dec 13, 2024
@jakobe jakobe moved this from ⭐ Planned Work to 🚀 In Progress in Kirby Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request NOT Tech refined Needs Tech kickoff - solution outlined and agreed
Projects
Status: 🚀 In Progress
Development

No branches or pull requests

1 participant