Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Suggest to use non case sesitive comparison for nodes.csv mac addresses #95

Open
TheApeMachine opened this issue Sep 28, 2021 · 1 comment

Comments

@TheApeMachine
Copy link

Current situation

I was setting things up and got an error on racker factory check about it not being able to determine PXE interface by looking at the columns of mac addresses.
Looking at the code I was able to figure out what I was doing wrong, however I used capitals because that is how the are shown to me by various tools (not all though).

Impact

Not very high, likely it is a convention to use lower-casing that I am not aware about.

Ideal future situation

use Go's strings.EqualFold here to remove the likelihood of it happening for other people.

**Implementation options

See above.

Additional information

Everything is working out great so far.

@pothos
Copy link
Member

pothos commented Sep 28, 2021

Thanks for creating the issue and giving feedback!
Yes, a simple conversion to lowercase with tr in the pipe would prevent this (There are some places to do this change, though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants