From 143215bd2c87252b2ff028802198b10848758ea3 Mon Sep 17 00:00:00 2001 From: Mateusz Gozdek Date: Sat, 31 Oct 2020 17:58:05 +0100 Subject: [PATCH 1/3] .github/workflows/ci.yaml: update golangci-lint to v1.33.0 Signed-off-by: Mateusz Gozdek --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index aa05171d3..86978d869 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -27,7 +27,7 @@ jobs: lint: name: Lint runs-on: ubuntu-latest - container: golangci/golangci-lint:v1.31.0 + container: golangci/golangci-lint:v1.33.0 timeout-minutes: 10 steps: From bb9a4561ae19c4ba9c92861ae8f0c696c77becc9 Mon Sep 17 00:00:00 2001 From: Mateusz Gozdek Date: Sat, 31 Oct 2020 19:20:08 +0100 Subject: [PATCH 2/3] .github/workflows/ci.yaml: fix codespell skip option Using spaces in it make it only check listed files I think. Also sync with .codespell.skip file, so we get consistent behavior across local execution and CI. Also avoid using wildcard on components, so we have a chance to fix reported typos upstream before we skip them from checking. Signed-off-by: Mateusz Gozdek --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 86978d869..f58479b68 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -49,7 +49,7 @@ jobs: - name: Codespell test uses: codespell-project/actions-codespell@master with: - skip: vendor, ./lokoctl, *.png, assets/charts/components/*, docs/images/*, + skip: ./vendor,./.git,./lokoctl,*.png,./assets/charts/components/cert-manager,./assets/charts/components/external-dns,./assets/charts/components/rook,./assets/charts/components/prometheus-operator,./assets/charts/components/velero,./assets/charts/components/cluster-autoscaler,./assets/charts/components/contour/crds,./assets/charts/components/openebs-operator/README.md,./assets/charts/control-plane/calico/crds,./docs/images/lokomotive-example.gif ignore_words_file: './.codespell.ignorewords' check_filenames: true check_hidden: true From c22ba6cd65eeff54f79f8c367bee231ae23a6e3f Mon Sep 17 00:00:00 2001 From: Mateusz Gozdek Date: Fri, 6 Nov 2020 09:14:54 +0100 Subject: [PATCH 3/3] Makefile: remove trailing comma from codespell skip argument Signed-off-by: Mateusz Gozdek --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index fad88faf1..985f90674 100644 --- a/Makefile +++ b/Makefile @@ -162,7 +162,7 @@ build-and-publish-release: goreleaser release --release-notes <(./scripts/print-version-changelog.sh) .PHONY: codespell -codespell: CODESPELL_SKIP := $(shell cat .codespell.skip | tr \\n ',') +codespell: CODESPELL_SKIP := $(shell cat .codespell.skip | tr \\n ',' | sed 's/,$$//g') codespell: CODESPELL_BIN := codespell codespell: which $(CODESPELL_BIN) >/dev/null 2>&1 || (echo "$(CODESPELL_BIN) binary not found, skipping spell checking"; exit 0)