Debugging ts in plugins #2

kimjoar · 2017-07-28T14:57:52Z

npm install in root,
npm install in packages/@elastic/kbn-types, then npm build in that folder
npm install in core_plugins/pid, then run npm run build or ./node_modules/.bin/webpack in that folder and you'll get the error

src/PidPlugin.ts(16,38): error TS2345: Argument of type 'Observable<PidConfig | undefined>' is not assignable to parameter of type 'Observable<PidConfig | undefined>'.
  Property 'source' is protected but type 'Observable<T>' is not a class derived from 'Observable<T>'.

) * Children of buttons won't capture hover events in firefox Fixes elastic#12987 * Make full screen div accessible * Remove nested aria labels

…astic#12611) * Fixes elastic#12602 - Change TSVB Fields API to use fieldCaps API * Removing obsolete test * updating tests * removing the extra sortBy

We need to revisit how we embed translations into templates, so until we do we might as well go back to embedding text directly in the page. The translation implementation now makes it difficult to navigate throughout complicated HTML. It also suffers from an inability to flag on unused translation keys, which creates a good deal of technical debt. Close to half of all translation keys in the translation file in this initial pilot were already unused since it was introduced a couple of months ago.

* Refactor how `get_ids` works to enable fetching other properties of index patterns, specifically the `title` or name * Remove unnecessary lines * Only cache for `id` calls

* Initial commit * added actual config * version 0.0.1 * version 0.0.2 * [no-const-assign] Disallow assignment to const http://eslint.org/docs/rules/no-const-assign * [no-redeclare] Disallow redeclaring variables http://eslint.org/docs/rules/no-redeclare * version 0.0.3 * [no-unused-vars]: Disallow declaration of variables that are not used in the code. * Bump to 0.1.0. * upgrade deps in preperation for babel6 transition * 0.2.0-alpha1 * use yaml for readability * 0.2.0 * update/pin peed dependency versions * 0.2.1 * [quotes] allow template literals This allows eslint to validate this rule from the styleguide: https://github.com/elastic/kibana/blob/master/style_guides/js_style_guide.md#use-template-strings-to-avoid-escaping-single-quotes * 0.2.2 * add object-curly-spacing and no-global-assign rules * sort .eslintrc.yaml rules * 0.3.0 * add basic react support * 0.4.0 * Disallow using 'context' in tests * 0.5.0 * move from .eslintrc.yaml to .eslintrc.js without .json generation (elastic#6) * Implement import plugin (elastic#7) * update deps * include eslint-plugin-import * Dereference import config (elastic#8) * reorganize existing rules into groups * defreference eslint-plugin-import "recommended" config Based on https://github.com/benmosher/eslint-plugin-import/blob/ea9c92c7324473ef303ac76b127e17af2becd2ee/config/recommended.js * 0.6.0 * set environment info for import rule * 0.6.1 * update peerDependencies * 0.7.0 * Move eslint-config-kibana into packages directory

* remove inline awaits * testSubjects.find now always returns a promise, so we need to make sure there is no more inlining * more find conversions * need to pass property name * Make sure async functions are awaited on.

Signed-off-by: Tyler Smalley <[email protected]>

Proxy support for plugin installer

Caused last 4 builds to fail on master. Will attempt to bring back in elastic#13034

* Add linting rules for formatting JSX. * Bump eslint config version to 0.8.0.

* ensure timezone attribute is adhered to Two issues - one the archiver was loading the visualize mapping after the config setting so it was bring overwritten, and two, uiSettings.replace wasn’t working correctly to begin with. * extra line to ensure server is stabilized to prevent transitory failures

…#13122) I untar'd data.json as it makes it harder to grep/update/review. Signed-off-by: Tyler Smalley <[email protected]>

…screen-reader accessible. (elastic#13046) * Make 'time picker' button in Discover no results prompt keyboard and screen-reader accessible.

…3084)

* handle data sets with holes * add unit tests

* Fix incorrect peerDependency and bump eslint config version to 0.8.1. * Upgrade eslint config to 0.8.1. Fix JSX to adhere to new formatting rules.

Since versions are synced across the stack, the esvm config can use the same branch configuration as Kibana itself.

* Stabalize tests and bring back flaky test * Try to fix flaky map radius visualize test * fix flaky tile map zoom test * Try to fix flaky zoom test by avoiding zooming in and out with spy panel open * Remove duplicate wrapped retry around find methods The retry was moved internally, around a check for stale elements as well, so this should no longer be neccessary.

… when loading Console app state. (elastic#13092)

* adding docs for goal and gauge

…agated to the UI (elastic#13004) * Remove try/catch for short url so the appropriate errors will be propagated to the UI * Simply ensure the error is a Boom error by wrapping it, but keep the original error details. * Boom.wrap can't handle non Error instances, as exist in some of the tests. * Only support Error objects, and check both status and statusCode * fix test * Fix test errors for reals this time * Break out status and statusCode short url error tests

Signed-off-by: Tyler Smalley <[email protected]>

* Initial check-in to replace gridster with react-grid-layout and reactify panels * # This is a combination of 3 commits. # This is the 1st commit message: Add margin of error to test determining panel widths # This is the commit message #2: use real kibana version when creating panel data. Will make future conversions easier. # This is the commit message #3: Fix lint errors * Add margin of error to test determining panel widths use real kibana version when creating panel data. Will make future conversions easier. Move default height and width to dashboard_constants so those that need it don't end up including extra stuff like ui/chrome * Remove unnecessary _.once when creating react directives in dashboard.js * Remove unnecessary constructors * Use componentDidMount instead of componentWillMount bc of async calls, and handle case where destroyEmbeddable is not defined. * Remove unnecessary null in classNames * Use loads defaultsDeep instead of Object.assign * use render* instead of get* for functions returning an element * use relative css paths * Use local import path * Switch to local imports and remove need for plugins path in jest tests * Improve accessibility of max/min panel toggle icon * remove unused css Had to implement this via code * disable eslint rule for setState in componentDidMount Am not aware of a better way to handle this, aside from switching to redux, since it’s recommended not to put async calls in componentWillMount. Since I plan to investigate redux next, disabling for now. Open to other’s opinions on the matter. * Use native map instead of lodash * Have the grid handle setting the z-indexes of the right reactgriditem * Make the draggable handle the title, not the whole heading Otherwise the drag event often takes over click events when trying to open the panel options menu and it gets really annoying. * Change from click to mouse down detector in KuiOutsideClickDector so drags also close pop ups. * Fix mistaken commit Code from the redux PR snuck into this one. * Run getEditPath and getTitle async calls in parallel - no need to wait on the return value of one before starting the others. * Fix tests: update snapshots, add promise returns. * version being added to panelData in the wrong spot caused isDirty flag to be true when it shouldn't be * Fix unmounting/mounting problem with panels due to view/edit mode switch * Fix bug where panels get squashed to one side when view mode is changed while a panel is expanded. * Update snapshots to match wrong view mode comparison * Improve naming of a variable * Fix issue with pop over hiding behind tile maps * Previous panel.js included ui/doc_table and ui/visualize - needed to include them in the chain for Dash only mode but not in that file. * Fix bad merge: remove baseline screenshots

* Add EUI v0.0.7 as a dependency. - Add support for using dark theme EUI CSS in Dashboard. - Set light theme as the default. - Add comments to chrome.jade about role of theme node. - Add (WTFPL OR MIT) to acceptable licenses. * Remove old reset CSS. - Remove naked element selectors from base.less. - Remove Bootstrap resets. - Remove UI Framework reset. - Remove unused reset styles from UI Framework. * Fix CSS regressions caused by removal of CSS reset. - Replace usage of sr-only with euiScreenReaderOnly. - Apply euiButtonEmpty classes to the 'Add a filter' button. - Fix Notification padding and layout. - Apply euiTabs styles to Timepicker mode tabs. - Fix layout of Available Fields heading in Discover. - Add padding to Popular Fields container in Discover. - Push down Selected Fields heading in Discover sidebar. - Fix appearance of links in Discover sidebar. - Fix height of pills in Filter Bar. * Fix timepicker tests. - Remove kbn-accessible-click from timepicker buttons. * Fix functional tests. - Use byCssSelector inside of testSubjects.find. - Delete flaky view_edit.js test: 'when time changed is stored with dashboard'. - Delete flaky view_edit.js test: 'and preserves edits on cancel > when time changed is stored with dashboard'. - Delete flake Gauge Chart tests. EUI changed the font size, and the text within the gauges doesn't render when the window is too small.

stacey-gammon and others added 30 commits July 24, 2017 09:01

Children of buttons won't capture hover events in firefox (elastic#13015

2f23303

) * Children of buttons won't capture hover events in firefox Fixes elastic#12987 * Make full screen div accessible * Remove nested aria labels

Should only fit on shapes that are part of the result (elastic#12881)

37fc949

Fixes elastic#12602 - Change TSVB Fields API to use fieldCaps API (el…

190cd5f

…astic#12611) * Fixes elastic#12602 - Change TSVB Fields API to use fieldCaps API * Removing obsolete test * updating tests * removing the extra sortBy

Branching for 6.0: bump version to 7.0.0-alpha1

e676668

[Management] Provide a way to fetch index pattern titles (elastic#13030)

89c7456

* Refactor how `get_ids` works to enable fetching other properties of index patterns, specifically the `title` or name * Remove unnecessary lines * Only cache for `id` calls

override version until elastic/elasticsearch#25876 is merged

ce8333b

Remove premature abstraction (elastic#13042)

95d3a37

remove inline awaits (elastic#13043)

c8848a4

* remove inline awaits * testSubjects.find now always returns a promise, so we need to make sure there is no more inlining * more find conversions * need to pass property name * Make sure async functions are awaited on.

Updates esArchiver mappings to use single type (elastic#13107)

460157d

Signed-off-by: Tyler Smalley <[email protected]>

Plugin installer proxy support (elastic#12753)

008cf03

Proxy support for plugin installer

skip flaky discover test (elastic#13114)

fbec367

Caused last 4 builds to fail on master. Will attempt to bring back in elastic#13034

Add linting rules for formatting JSX. (elastic#12810)

b3ffd99

* Add linting rules for formatting JSX. * Bump eslint config version to 0.8.0.

Removed _default_ from esArchiver test and updates data.json (elastic…

e77e64b

…#13122) I untar'd data.json as it makes it harder to grep/update/review. Signed-off-by: Tyler Smalley <[email protected]>

Make 'time picker' button in Discover no results prompt keyboard and …

1675529

…screen-reader accessible. (elastic#13046) * Make 'time picker' button in Discover no results prompt keyboard and screen-reader accessible.

Update filter editor docs with addition of advanced option (elastic#1…

e3aeb0b

…3084)

date_histogram: some bars are too big (elastic#13068)

dd8c1ab

* handle data sets with holes * add unit tests

Upgrade eslint config to 0.8.1. (elastic#13128)

e922f00

* Fix incorrect peerDependency and bump eslint config version to 0.8.1. * Upgrade eslint config to 0.8.1. Fix JSX to adhere to new formatting rules.

esvm: use branch from package.json (elastic#13149)

8d5eac9

Since versions are synced across the stack, the esvm config can use the same branch configuration as Kibana itself.

Add unit tests the verify correct dataType in jQuery.ajax request…

2bee8bb

… when loading Console app state. (elastic#13092)

Save layer setting in the region map UI (elastic#12956)

9b949a5

Region map should respect saved center and zoom (elastic#12883)

5e9a4ec

[eslint-config-kibana] Add jest plugin and settings (elastic#13090)

3884d38

fix metric default color (elastic#12993)

fbd9fd0

adding docs for goal and gauge (elastic#13140)

1e6ce85

* adding docs for goal and gauge

Fix typos and punctuation in WMS settings (elastic#13146)

d14da34

timroes and others added 2 commits August 23, 2017 16:31

Remove custom keyboard mode in datepicker (elastic#13644)

d3a62e8

Removes webpack-directory-name-as-main dependency (elastic#13584)

4bbd127

Signed-off-by: Tyler Smalley <[email protected]>

kimjoar force-pushed the platform/extract-core-plugins branch 6 times, most recently from c686f81 to 38dbf4c Compare August 24, 2017 06:50

kimjoar added 2 commits August 24, 2017 14:20

Merge branch 'master' into new-platform

7e7ff40

Fix dates in tests (elastic#13744)

0ebaa8d

kimjoar force-pushed the platform/extract-core-plugins branch 2 times, most recently from 3792f33 to 1a8441c Compare August 30, 2017 05:27

kimjoar added 2 commits August 30, 2017 08:30

Make core plugins use kbn-types

6f9eec4

Extract core plugins

1ec709d

kimjoar force-pushed the platform/extract-core-plugins branch from 1a8441c to 44b57e5 Compare August 30, 2017 05:31

kimjoar added 2 commits August 30, 2017 08:33

Add package lock files

407cbb6

Move getPluginDir into Env

a0c309c

kimjoar force-pushed the platform/extract-core-plugins branch from 44b57e5 to a0c309c Compare August 30, 2017 05:33

kimjoar added 7 commits August 31, 2017 10:34

Review fixes

2bc67cd

Ensure 'target' is removed before re-building plugin

628180f

Update package.lock

6605033

Run prettier

27640f8

Fix typo

0b430dc

Remove unnecessary mention of tsconfig.json

0a6ebb5

Update platform readme

75a4a6f

kimjoar closed this Sep 6, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Debugging ts in plugins #2

Debugging ts in plugins #2

kimjoar commented Jul 28, 2017

Debugging ts in plugins #2

Debugging ts in plugins #2

Conversation

kimjoar commented Jul 28, 2017