Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asbplayer website no longer captures exact frame #549

Open
UmbralCosmos opened this issue Oct 23, 2024 · 9 comments
Open

asbplayer website no longer captures exact frame #549

UmbralCosmos opened this issue Oct 23, 2024 · 9 comments

Comments

@UmbralCosmos
Copy link

Before submitting an issue check out the common issues section of the README:

The problem only involves the mined picture.

On the website, using shift+ctrl+x to capture a moment and create an anki diologue, the picture is no longer the exact moment but a single frame for a set amount of time.

For example, I can only get 1 specific frame within 1 second, preventing me from getting the exact picture I want.

This was not the case at least a few months ago.

Chrome Version 130.0.6723.59 (Official Build) (64-bit)

Local video

@UmbralCosmos
Copy link
Author

It seems this was addressed but I am still having this problem.

#238 (comment)

@killergerbah
Copy link
Owner

Is the problem you're experiencing that the 'manually take screenshot' shortcut does not work?

@UmbralCosmos
Copy link
Author

Is the problem you're experiencing that the 'manually take screenshot' shortcut does not work?

No,
"you're right, it looks I broke the "current frame" behavior at some point. I've pushed the fix for that; let me know what you think."
is the comment I referenced.

When I try to mine the current subtitle, the captured image is not of the frame I'm on.
It is the frame at the beginning of the subtitle.

The "manually take screenshot" doesn't work either but I never had any need of it before now anyways.

@killergerbah
Copy link
Owner

@UmbralCosmos Unfortunately, I'm unable to reproduce the issue. Are you using https://killergerbah.github.io/asbplayer/ with the latest version of the extension (1.5.0)?

@UmbralCosmos
Copy link
Author

@killergerbah I am not using the extension. Just the website. Only use it with local videos.

@UmbralCosmos
Copy link
Author

@killergerbah It seems this occurs on some types of videos.
I have 3 series in .mkv and this issue occurs in only one of them.
Having subtitles or not doesn't seem to affect anything.
Would you like me to send the video files?

@mathiaslovnes
Copy link

mathiaslovnes commented Oct 31, 2024

I'm experiencing this exact issue! I can understand why you're not able to replicate it @killergerbah as this only occurs on some shows/files. I downloaded Legend of the Galactic Heroes season 1 from two different users on nyaa, and it happens on both, but not on the prequel movie. Nor on any other local files.

It's exactly as @UmbralCosmos is describing it, it captures the screenshot of the frame at the beginning of the next subtitle.
EDIT: I am using https://killergerbah.github.io/asbplayer/ with the latest update, (1.5.0)

@killergerbah
Copy link
Owner

If i had a to guess the problem has more to do with seek imprecision related to the video file itself rather than asbplayer screwing up the screenshot logic

Ill look into it more but posting my hypothesis above in case it is consistent with your observations

@OscarMatt91
Copy link

I'm also having this issue but it started happening in the middle of a show so should be all the same type of file (I started watching Shirokuma Cafe and screenshots were fine but around ep 30 it started having this issue when the screenshot is from the next subtitle)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@killergerbah @mathiaslovnes @UmbralCosmos @OscarMatt91 and others